Fix C# "out of sync" notice with external editors #88076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change what triggers our re-evaluation of the last valid build datetime stored internally. Move that datetime in `BuildManager`.
paulloz
force-pushed
the
dotnet/fix-out-of-sync-notice-with-external-editors
branch
from
a7368f1 to
9d28306
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notice introduced in #85869 wasn't being dequeued when building from an external IDE. This PR fixes it by changing what triggers our reevaluation of the last valid build time. We used to react only to Godot's internal build process. We're now reacting to assembly reload, which is triggered both by building from Godot, and from the watcher.
Thanks @Delsin-Yu @zaevi for pointing out the issue.