Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Bump closure compiler spec to ECMASCRIPT_2021 #88010

Merged

Conversation

akien-mga
Copy link
Member

Fixes #88008.

@akien-mga akien-mga added bug platform:web topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 6, 2024
@akien-mga akien-mga added this to the 4.3 milestone Feb 6, 2024
@akien-mga akien-mga requested a review from a team as a code owner February 6, 2024 08:19
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's fine to use ECMAScript 2021.

See support for the ||= which #88008 complains about:
https://caniuse.com/mdn-javascript_operators_logical_or_assignment

Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me!

@akien-mga akien-mga changed the title Web: Bump closure compiler spec to ECMASCRIPT_2021 Web: Bump closure compiler spec to ECMASCRIPT_2021 Feb 7, 2024
@akien-mga akien-mga merged commit 7cd3467 into godotengine:master Feb 7, 2024
16 checks passed
@akien-mga akien-mga deleted the web-closure-ECMASCRIPT_2021 branch February 7, 2024 10:15
@akien-mga
Copy link
Member Author

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 9, 2024
@akien-mga
Copy link
Member Author

Cherry-picked for 3.6.
Cherry-picked for 3.5.4.

@akien-mga akien-mga removed cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web editor build with closure compiler fails to compile with Emscripten 3.1.53
3 participants