-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emscripten 3.1.51 breaking change about *glGetProcAddress()
#87981
Fix emscripten 3.1.51 breaking change about *glGetProcAddress()
#87981
Conversation
c484aec
to
5922ac0
Compare
Thanks! |
Hm, I don't think we should be relying on |
Cherry-picked for 4.2.2. |
Cherry-picked for 3.6. |
I came across this one again, because I'm debugging an unrelated issue concerning Emscripten 3.1.51. I really think this PR was the wrong way to go. As I said previously, we really shouldn't need If we chose not to use the |
Another note from the Emscripten docs about how |
Rather than just complaining, I've started draft PR #93489 :-) |
Since emscripten 3.1.51, a link flag is now required in order to use
*glGetProcAddress()
family of functions.This PR fixes that breaking change.
We use
*glGetProcAddress()
(relating to the web platform) in:drivers/gles3/rasterizer_gles3.cpp
drivers/gles3/storage/config.cpp
A check is done to apply the link flag
-s GL_ENABLE_GET_PROC_ADDRESS
only if it detects emscripten ≥ 3.1.51.