Add workaround for emscripten >= 3.1.47 LTO build #87956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Feb 5, 2024
akien-mga
added
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
cherrypick:4.1
|
Cherry-picked for 3.6. |
akien-mga
removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround to
platform/web/detect.pyin order to add-Wl,-u,_emscripten_run_callback_on_threadas a linker flag if the emscripten version is equal or higher than 3.1.47, when building with LTO enabled. It was suggested as a workaround on emscripten-core/emscripten#16836.I commented and shared my findings here: emscripten-core/emscripten#16836 (comment)
Fixes #87611
Fixes godotengine/godot-docs#8589