Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression when multiple nodes are selected and drag transform is attempted w/o gizmo #87922

Conversation

ryevdokimov
Copy link
Contributor

#87769 fixes a regression but introduces another. I misunderstood get_single_selected_node and thought it would still return a node if multiple were selected node, but it actually returns false and ends up breaking transforms done via dragging outside the gizmo. This PR replaces that method with a check if more than 0 nodes are selected.

@ryevdokimov ryevdokimov requested a review from a team as a code owner February 4, 2024 02:57
@akien-mga akien-mga added this to the 4.3 milestone Feb 4, 2024
@akien-mga akien-mga merged commit 64cee8a into godotengine:master Feb 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@ryevdokimov ryevdokimov deleted the all-tools-can-select-regression-2 branch February 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants