Add HeightMapShape3D functions to get min / max height #87881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
height_min_max_helpers
branch
from
4d323d9 to
297223e
Compare
Mickeon
reviewed
Feb 2, 2024
smix8
force-pushed
the
height_min_max_helpers
branch
from
297223e to
f475a86
Compare
kleonc
reviewed
Feb 3, 2024
Adds HeightMapShape3D functions to get min / max height.
smix8
force-pushed
the
height_min_max_helpers
branch
from
f475a86 to
0a485fc
Compare
Mickeon
approved these changes
Feb 4, 2024
kleonc
approved these changes
Feb 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
HeightMapShape3Dfunctions to getmin/maxheight.Not sure why those were never exposed while already tracked on the shape. Knowing what is the min and max height in the heights array is very useful information to avoid looping over the entire large array manually.
Also there are no longer pool arrays in Godot 4, they are now packed arrays, but I don't see much value in mentioning this in the text when the function makes it obvious.