Fix vertical zoom factor in Animation Bezier Editor #87857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
requested changes
Feb 11, 2024
CookieBadger
force-pushed
the
animation-bezier-editor-fix-zoom-factor
branch
from
63b0195 to
726a5cb
Compare
TokageItLab
requested changes
Feb 12, 2024
CookieBadger
force-pushed
the
animation-bezier-editor-fix-zoom-factor
branch
from
726a5cb to
62cb48f
Compare
TokageItLab
approved these changes
Feb 12, 2024
|
You'll need a rebase to fix CI I think |
|
Are you able to do the git rebase within the next few weeks? We could try helping out. https://docs.godotengine.org/en/stable/contributing/workflow/pr_review_guidelines.html |
akien-mga
changed the title
akien-mga
force-pushed
the
animation-bezier-editor-fix-zoom-factor
branch
from
62cb48f to
b66b188
Compare
|
Rebased. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed, that with my recent PR #85142 I made the timeline zooming in the Bezier editor more usable, but the vertical zooming of values is now way too small.
This PR fixes that, by using the timeline zoom constant only for zooming on the time axis.