Restore previous script open behavior for EditorPlugins #87722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a hack to me. And tbh the original PR was also kind of a hack and spawned more regressions (#88061). Maybe a proper fix would be some way to edit a resource without opening it in the inspector. |
|
I agree @KoBeWi, but I also think that would likely be a much more intrusive change, and at that point I'd argue maybe the best course would be to simply revert the original change and restore the old behavior. Then consider reimplementing the fix targeting 4.4+ at this point so that we can fully validate a working solution without regressions. wdyt? |
|
4.3 beta is still a month away, I'll try to come up with a fix before then. |
|
Superseded by #88288. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87383