Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check in CompressedTextureLayered::get_layer_data to prevent crash #87694

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add check in CompressedTextureLayered::get_layer_data to prevent crash #87694

merged 1 commit into from
Feb 16, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #87367

@AThousandShips AThousandShips added this to the 4.3 milestone Jan 29, 2024
@AThousandShips AThousandShips requested a review from a team January 29, 2024 10:18
AThousandShips
AThousandShips approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise!

scene/resources/compressed_texture.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit ebf00b8 into godotengine:master Feb 16, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug crash topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Executing CompressedCubemap.get_layer_data function crashes Godot
3 participants
@jsjtxietian @akien-mga @AThousandShips