Mention Multiplayer.get_remote_sender_id's 0 after await
#87610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
commented
Jan 26, 2024
| @@ -34,7 +34,7 @@ | |||
| <return type="int" /> | |||
| <description> | |||
| Returns the sender's peer ID for the RPC currently being executed. | |||
| [b]Note:[/b] If not inside an RPC this method will return 0. | |||
| [b]Note:[/b] This method returns [code]0[/code] when called outside of an RPC. As such, the original peer ID may be lost when code execution is delayed (such as with GDScript's [code]await[/code] keyword). | |||
There was a problem hiding this comment.
Alternative take of the same line:
Suggested change
| [b]Note:[/b] This method returns [code]0[/code] when called outside of an RPC. As such, the original peer ID may be lost when code execution is delayed (such as with GDScript's [code]await[/code] keyword). | |
| [b]Note:[/b] This method returns [code]0[/code] when called outside of an RPC. Delaying code execution (such as with GDScript's [code]await[/code] keyword) may bring the RPC out of context. |
mhilbrunner
approved these changes
Mar 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86719
It does not hurt to be more explicit. I considered adding a visual example but this looks good enough.