Remove now unused year member from version.py
#87543
Merged
+17
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Jan 24, 2024
akien-mga
commented
Jan 24, 2024
akien-mga
force-pushed
the
version-remove-year
branch
from
6aeb73c to
fe7832e
Compare
akien-mga
force-pushed
the
version-remove-year
branch
3 times, most recently
from
53be582 to
ee2e45e
Compare
akien-mga
commented
Jan 24, 2024
akien-mga
force-pushed
the
version-remove-year
branch
2 times, most recently
from
0cc49e9 to
72f64dd
Compare
akien-mga
commented
Jan 24, 2024
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jan 25, 2024
Seems like we missed this one when changing the copyright statements to use `present` instead of the hardcoded `year`. And backport other minor improvements from godotengine#87543.
YuriSizov
approved these changes
Jan 25, 2024
We changed copyright to use "present" for the current year, so we no longer need to hardcode this and (like now) forget to bump it yearly.
akien-mga
force-pushed
the
version-remove-year
branch
from
72f64dd to
e0dc233
Compare
AThousandShips
approved these changes
Jan 25, 2024
mhilbrunner
approved these changes
Jan 25, 2024
|
Thanks! |
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jan 30, 2024
Seems like we missed this one when changing the copyright statements to use `present` instead of the hardcoded `year`. And backport other minor improvements from godotengine#87543. (cherry picked from commit f61e249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed copyright to use "present" for the current year, so we no longer need to hardcode this and (like now) forget to bump it yearly.
Technically it breaks compat by removing
yearfrom theEngine.get_version_info()dictionary.I think it's in the scope of acceptable changes for 4.3, but shouldn't be cherry-picked to 4.2.x (instead, we'll just bump the
yearto 2024).Non-compat breaking version for
3.x: #87579