Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redraw TreeItem on more changes #87415

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Redraw TreeItem on more changes #87415

merged 1 commit into from
Jan 22, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Jan 20, 2024 •
edited
Loading

  • Custom font changes
  • Custom draw changes
  • Custom as button

Looking into detecting changes to the font itself to do updates but unsure if desired so will hold off on that for the time being (in that case I would look into doing it for all the relevant resource types, like for set_icon, add_button, set_button, etc.)

@AThousandShips AThousandShips added bug topic:gui cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 20, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jan 20, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner January 20, 2024 15:43
@AThousandShips AThousandShips force-pushed the tree_font branch 2 times, most recently from c3b66ab to be8ee9c Compare January 20, 2024 16:50
@AThousandShips AThousandShips changed the title Redraw TreeItem on setting custom font Redraw TreeItem on more changes Jan 20, 2024
@AThousandShips
Copy link
Member Author

While looking at the additional changes I realized that it's impossible to clear the custom draw for a TreeItem, making a PR to add that

@AThousandShips
Redraw TreeItem on more changes
552594f 
* Custom font changes
* Custom draw changes
* Custom as button
@YuriSizov YuriSizov merged commit fc25ff0 into godotengine:master Jan 22, 2024
16 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@AThousandShips AThousandShips deleted the tree_font branch January 22, 2024 19:47
@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

SetCustomFont() and SetCustomFontSize() don’t redraw TreeItem
3 participants
@AThousandShips @YuriSizov @KoBeWi