Remove unnecessary _set_global_invalid added by mistake
#87328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jan 18, 2024
Sauermann
approved these changes
Jan 18, 2024
akien-mga
changed the title
_set_global_invalid added by mistake
|
Thanks! |
akien-mga
changed the title
_set_global_invalid added by mistake_set_global_invalid added by mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mistake was introduced in #87115 but the issue was already solved in #86841.
The call to
_set_global_invalidis indeed already done at line 319.(I marked it as a bug, but I don't think it has any impact. I marked it a "bug" because it's solving a mistake. If that makes any sense 😅 )