Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve editor theme generation after the refactor #87293

Merged

Conversation

YuriSizov
Copy link
Contributor

Follow-up to #87085.

  • Fixes a bug with the color mode of icons and fonts not respecting the color preset.
  • Fixes a bug with the benchmark by moving benchmarking code to the main class and tracking the number of runs.
  • As a cleanup step, moves is_dark_theme() from EditorSettings to EditorThemeManager.
  • Adds a hashing mechanism to easily compare editor settings affecting the theme generation.
  • Updates the icon generation to use this mechanism, and adds notes for future improvements to fonts and styles.
  • Properly tracks the subresource_hue_tint setting and accounts for it when deciding to regenerate the theme.
  • Removes EDITOR_GETs from editor_icons.cpp to better consolidate them in the main file.
    • This also needs to be done in some way to editor_fonts.cpp, but that's a more complex task for now.
  • Some less notable cleanup.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a cursory review.

@akien-mga akien-mga merged commit 33f3511 into godotengine:master Jan 18, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov deleted the editor-theme-a-rehashed-follow-up branch January 18, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants