Properly change GridMap floors while selecting #87131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
skyscrapper_selector_simulator
branch
from
e6e83af to
80341da
Compare
Calinou
added
the
cherrypick:4.2
Calinou
reviewed
Jan 12, 2024
|
It only works while still dragging. I guess that's another difference, as previously you were able to Shift+Q/E after releasing mouse button (though it feels like a bug). I opened this PR as a quick bugfix, and to see if such behavior is acceptable. I can try improving it if it's not good enough. |
|
So should we go ahead with the current partial fix, or spend time to figure out how to solve the issue when not dragging? |
Please move it forward! This is blocking the Lingo team from updating beyond 4.1. |
akien-mga
approved these changes
Jun 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87107
klcFJlNRf7.mp4
Note that behavior is still different than in the previous versions. You need to release Shift to use E and Q, also it changes the current selection position, instead of the origin like it did previously.