Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix position and basis of 3D Scenes instantiated via drag and drop #87126

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix position and basis of 3D Scenes instantiated via drag and drop #87126

merged 1 commit into from
Feb 14, 2024

Conversation

ryevdokimov
Copy link
Contributor

@ryevdokimov ryevdokimov commented Jan 12, 2024 •
edited
Loading

Fixes #84424

Supersedes #84438

2024-01-12.13-41-09.mp4

image

@ryevdokimov ryevdokimov requested a review from a team as a code owner January 12, 2024 18:26
@AThousandShips AThousandShips added this to the 4.3 milestone Jan 12, 2024
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 12, 2024
@aaronfranke
Copy link
Member

See also #81892

@ryevdokimov ryevdokimov mentioned this pull request Jan 13, 2024
Merged
@ryevdokimov ryevdokimov mentioned this pull request Jan 26, 2024
Merged
@ryevdokimov
Copy link
Contributor Author

ryevdokimov commented Feb 13, 2024 •
edited
Loading

Don't archive. I will reopen this, I just screwed up.

@AThousandShips AThousandShips removed this from the 4.3 milestone Feb 13, 2024
@ryevdokimov ryevdokimov reopened this Feb 13, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 13, 2024
akien-mga
akien-mga approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, this seems to behave as I would expect it, similar to how it does with 2D nodes.

@akien-mga akien-mga requested a review from Calinou February 14, 2024 10:12
@akien-mga akien-mga mentioned this pull request Feb 14, 2024
Closed
@akien-mga akien-mga merged commit a1cc379 into godotengine:master Feb 14, 2024
32 of 40 checks passed
@akien-mga
Copy link
Member

Thanks!

@ryevdokimov ryevdokimov deleted the fix-84424(2) branch February 14, 2024 14:14
@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Mar 11, 2024
@akien-mga
Copy link
Member

Doesn't cherry-pick easily on 4.2, would need a dedicated backport PR.

@ryevdokimov ryevdokimov mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

3D objects dropped into the viewport do not respect original positioning and reset it to cursor position.
4 participants
@ryevdokimov @aaronfranke @akien-mga @AThousandShips