Add CanvasItem::get_canvas_layer_node()

[TML233]

• Added CanvasLayer::get_canvas_layer_node, which returns the CanvasLayer node the CanvasItem is in. Returns nullptr when the CanvasItem is not in a CanvasLayer node.

Fix godotengine/godot-proposals#8863

[Sauermann]

Please edit in your opening post the last line and change it to:
fix godotengine/godot-proposals#8863

This change will link this PR to that proposal and causes github to automatically close the proposal, when this PR gets merged. These keywords are explained in https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests.

[TML233]

Please edit in your opening post the last line and change it to: fix godotengine/godot-proposals#8863

This change will link this PR to that proposal and causes github to automatically close the proposal, when this PR gets merged. These keywords are explained in https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests.

Thank you! I've fixed both issues you mentioned.

[Sauermann]

I'm not familiar with ERR_READ_THREAD_GUARD_V, but otherwise the PR changes look correct.

[groud]

I think I am ok with exposing the node, as there seem to be no way to retrieve it easily otherwise.

I'd, however, avoid exposing get_canvas_layer. It bloating the API for something that could easily be done manually. See the function:

int CanvasItem::get_canvas_layer() const {
	ERR_READ_THREAD_GUARD_V(0);
	if (canvas_layer) {
		return canvas_layer->get_layer();
	} else {
		return 0;
	}
}

Also, I think the use case is not common enough to justify exposing get_canvas_layer.

[TML233]

I think I am ok with exposing the node, as there seem to be no way to retrieve it easily otherwise.

I'd, however, avoid exposing get_canvas_layer. It bloating the API for something that could easily be done manually. See the function:

int CanvasItem::get_canvas_layer() const {

	ERR_READ_THREAD_GUARD_V(0);

	if (canvas_layer) {

		return canvas_layer->get_layer();

	} else {

		return 0;

	}

}

Also, I think the use case is not common enough to justify exposing get_canvas_layer.

Okay, I'll de-expose get_canvas_layer but keep get_canvas_layer_node.

[Mickeon]

The commit could use a different name since get_canvas_layer is no longer exposed.

[Mickeon]

The documentation is completely fine, though

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉