Android: Disable automatic permissions request #87080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature was added in Godot 4.2, but it goes against recommended best practices for permissions request, as such it's being reverted. In its place, developers now have to explicitly request the permissions they need to access.
m4gr3d
added
platform:android
topic:porting
regression
cherrypick:4.2
m4gr3d
added a commit
to m4gr3d/godot_openxr_vendors
that referenced
this pull request
Jan 11, 2024
…manifest This is a follow-up of the changes made in godotengine/godot#87080
|
Thanks!I forgot to mark my approved review, but I did approve in my mind :P |
maunvz
pushed a commit
to maunvz/godot_openxr_vendors
that referenced
this pull request
Jan 12, 2024
…manifest This is a follow-up of the changes made in godotengine/godot#87080
m4gr3d
added a commit
to m4gr3d/godot_openxr_vendors
that referenced
this pull request
Jan 12, 2024
…manifest This is a follow-up of the changes made in godotengine/godot#87080
m4gr3d
added a commit
to GodotVR/godot_openxr_vendors
that referenced
this pull request
Jan 12, 2024
…manifest (#71) This is a follow-up of the changes made in godotengine/godot#87080
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature was added in Godot 4.2, but it goes against recommended best practices for permissions request, as such it's being reverted. In its place, developers now have to explicitly request the permissions they need to access.
Fixes #87043
Fixes m4gr3d/Godot-Android-Samples#14