Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Improve logger. #87077

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[iOS] Improve logger. #87077

merged 1 commit into from
Jan 11, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 11, 2024

  • Stream errors to the Console.app (and highlight in Xcode).
  • Prevent duplicate prints in Xcode.

Console.app:
Screenshot 2024-01-11 at 16 51 03

Xcode log:
Screenshot 2024-01-11 at 17 03 38

Fixes #87073

@bruvzg
[iOS] Improve logger.
c38c15b 
Stream errors to the Console.app (and highlight in Xcode).
Prevent duplicate prints in Xcode.
@bruvzg bruvzg added this to the 4.3 milestone Jan 11, 2024
@bruvzg bruvzg requested a review from a team as a code owner January 11, 2024 15:04
@akien-mga akien-mga merged commit 99f3e40 into godotengine:master Jan 11, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AdriaandeJongh
Copy link
Contributor

Dang, the same day I reported the issue! Really appreciated @bruvzg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug enhancement platform:ios topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Xcode output console prints every message twice
3 participants
@bruvzg @akien-mga @AdriaandeJongh