-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Button] Add autowrap feature. #87025
Conversation
Thanks for doing this PR, @bruvzg - hope it gets accepted soon. While I agree that the label's autowrap property is a glaring omission from Button, it's just one of potentially hundreds of properties we need to access regarding the label. I suggest exposing the label in the buttons API, so all the properties can be accessed at least through code. Currently, even subclassing Button doesn't give you access to the label. |
@klootas Buttons don't use labels internally. They draw the text directly. |
Oh, I see - thanks for the clarification. Then I think this PR fixes a pretty big shortcoming in a really good way.👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Needs a rebase.
Poke :) |
Thanks! |
Implements godotengine/godot-proposals#8823