Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Add autowrap feature. #87025

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 10, 2024

@bruvzg bruvzg added this to the 4.x milestone Jan 10, 2024
hemu0069

This comment was marked as off-topic.

hemu0069

This comment was marked as off-topic.

@bruvzg bruvzg marked this pull request as ready for review January 10, 2024 09:56
@bruvzg bruvzg requested review from a team as code owners January 10, 2024 09:56
@klootas
Copy link

klootas commented Jan 25, 2024

Thanks for doing this PR, @bruvzg - hope it gets accepted soon.

While I agree that the label's autowrap property is a glaring omission from Button, it's just one of potentially hundreds of properties we need to access regarding the label. I suggest exposing the label in the buttons API, so all the properties can be accessed at least through code. Currently, even subclassing Button doesn't give you access to the label.

@YuriSizov
Copy link
Contributor

@klootas Buttons don't use labels internally. They draw the text directly.

@klootas
Copy link

klootas commented Jan 25, 2024

@klootas Buttons don't use labels internally. They draw the text directly.

Oh, I see - thanks for the clarification. Then I think this PR fixes a pretty big shortcoming in a really good way.👍

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Needs a rebase.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 15, 2024
@akien-mga
Copy link
Member

Needs a rebase.

Poke :)

@akien-mga akien-mga merged commit 12817f2 into godotengine:master Feb 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants