-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing descriptions to PrimitiveMesh and SoftBody3D #87011
Merged
akien-mga
merged 1 commit into
godotengine:master
from
Mickeon:missing-description-primitive-mesh
Jan 15, 2024
Merged
Add missing descriptions to PrimitiveMesh and SoftBody3D #87011
akien-mga
merged 1 commit into
godotengine:master
from
Mickeon:missing-description-primitive-mesh
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
documentation
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
labels
Jan 9, 2024
Mickeon
force-pushed
the
missing-description-primitive-mesh
branch
from
January 9, 2024 16:29
a14a923
to
056fc84
Compare
Mickeon
force-pushed
the
missing-description-primitive-mesh
branch
from
January 9, 2024 16:31
056fc84
to
a33777d
Compare
nice one |
clayjohn
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PrimitiveMesh description looks good!
The SoftBody stuff also seems fine, but I'm less knowledgeable about that
rburing
approved these changes
Jan 14, 2024
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
label
Jan 24, 2024
Cherry-picked for 4.2.2. |
YuriSizov
removed
the
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
label
Jan 24, 2024
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ...💤💤...
... This brings them to 100% completion.
Pressure coefficient source: https://arxiv.org/ftp/physics/papers/0407/0407003.pdf
May require the insight from the Physics team for the missing SoftBody3D descriptions.