Fix member names of AudioFrame to match extension
#87006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Jan 9, 2024
|
|
||
| _ALWAYS_INLINE_ const float &operator[](int p_idx) const { | ||
| DEV_ASSERT((unsigned int)p_idx < 2); | ||
| return levels[p_idx]; |
There was a problem hiding this comment.
Could keep the old syntax here but nicer on release IMO and matches how we do in Vector2/3/4
vnen
reviewed
Jan 15, 2024
AThousandShips
force-pushed
the
frame_fix
branch
from
4357dee to
413bcf1
Compare
|
@YuriSizov only tangentially related to extensions, the alternative would be to rename the extension ones to |
|
@AThousandShips This is only an issue if we consider extensions to begin with, AFAIU. Which makes the GDExtension team a natural stakeholder in the solution, whether it touches extension code or not 🙂 |
|
True, though it's a style improvement nonetheless, though I suspect it might matter when using mixed code accessing both structures, but unsure |
akien-mga
approved these changes
Feb 13, 2024
AThousandShips
force-pushed
the
frame_fix
branch
from
413bcf1 to
d8b29ef
Compare
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran without the compatibility cases and it didn't complain about any unused cases so seems that all the old uses are fixed, would need someone to confirm though
Ran CI without the old names and didn't have any problems on those platforms so should be covered