Improve error message when a GDScript instance fails to be constructed #86999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Slashscreen <[email protected]>
AThousandShips
commented
Jan 9, 2024
vnen
approved these changes
Feb 8, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this wording works well, but could take some inspiration from #86635, would be up for either way
Salvaged from: Improve error message when a GDScript instance fails to be constructed #76632
Closes: Inform the users that non-default-constructible nodes are a bad thing godot-proposals#5899
Closes: Improve error message when Godot is unable to construct GDScriptInstance godot-proposals#8488