Fix ZIPPacker storing file permissions unexpectedly #86985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
added
bug
platform:linuxbsd
topic:core
regression
cherrypick:4.2
akien-mga
approved these changes
Jan 9, 2024
|
I just tested this commit, and it fixed the issue. Thank you. |
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86967
The "version made by" parameter indicates the compatibility of the file attribute information. Since 0 is stored in the related file attribute field, using
0x0314as "version made by" is effectly saying "I want the file's UNIX file permission to be 0".ZIPPackerdoes not support specifying file permissions, so it's safe to use 0 as "version made by", ignoring the file attribute information field.