Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build warning with memset value being too large #86920

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix build warning with memset value being too large #86920

merged 1 commit into from
Jan 9, 2024

Conversation

griffinkh
Copy link
Contributor

@griffinkh griffinkh commented Jan 7, 2024 •
edited by AThousandShips
Loading

Should resolve issue #83342

@griffinkh griffinkh requested a review from a team as a code owner January 7, 2024 13:23
@AThousandShips AThousandShips added this to the 4.3 milestone Jan 7, 2024
clayjohn
clayjohn requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using unsigned int this should use uint32_t, otherwise this seems great!

drivers/gles3/storage/texture_storage.cpp Outdated Show resolved Hide resolved
@griffinkh
Copy link
Contributor Author

change is made, thanks!

@akien-mga akien-mga requested a review from clayjohn January 8, 2024 17:26
clayjohn
clayjohn approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the quick update

@akien-mga akien-mga merged commit a56dd6c into godotengine:master Jan 9, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

GLES3: Texture's memset exceeds maximum object size
4 participants
@griffinkh @akien-mga @clayjohn @AThousandShips