Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Keystore Release password on Android's Export window #86882

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Hide Keystore Release password on Android's Export window #86882

merged 1 commit into from
Jan 8, 2024

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Jan 6, 2024

@Mickeon Mickeon requested a review from a team as a code owner January 6, 2024 14:46
@YeldhamDev YeldhamDev added this to the 4.3 milestone Jan 6, 2024
@Mickeon Mickeon force-pushed the its-a-secret-to-everyone branch from 1c9e720 to 38bc530 Compare January 6, 2024 17:39
@Mickeon Mickeon force-pushed the its-a-secret-to-everyone branch from 38bc530 to ca03367 Compare January 6, 2024 17:40
@Mickeon
Copy link
Contributor Author

Mickeon commented Jan 6, 2024

Updated the PR with the above requests

m4gr3d
m4gr3d approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akien-mga akien-mga merged commit c951ec1 into godotengine:master Jan 8, 2024
15 checks passed
@Mickeon Mickeon deleted the its-a-secret-to-everyone branch January 8, 2024 11:13
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:editor topic:export
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Hide Keystore password on android export window
4 participants
@Mickeon @akien-mga @m4gr3d @YeldhamDev