Add a few notes to Sprite3D's documentation #86872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
commented
Jan 6, 2024
| @@ -75,7 +75,8 @@ | |||
| If [code]true[/code], texture is flipped vertically. | |||
| </member> | |||
| <member name="modulate" type="Color" setter="set_modulate" getter="get_modulate" default="Color(1, 1, 1, 1)"> | |||
| A color value used to [i]multiply[/i] the texture's colors. Can be used for mood-coloring or to simulate the color of light. | |||
| A color value used to [i]multiply[/i] the texture's colors. Can be used for mood-coloring or to simulate the color of ambient light. | |||
| [b]Note:[/b] Unlike [member CanvasItem.modulate] for 2D, colors with values above [code]1.0[/code] (overbright) are not supported. | |||
There was a problem hiding this comment.
Calinou described a goord workaround but I feel like putting it here would bloat the description too much. Is it a common-enough to warrant giving example code?
Mickeon
force-pushed
the
documentation-sprite-3d-notes
branch
from
786047b to
8ca47c9
Compare
dalexeev
added
enhancement
documentation
cherrypick:4.1
akien-mga
approved these changes
Feb 13, 2024
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73739
Closes #75083
Can be cherrypicked for prior 4.x versions.