Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify how CanvasTexture does not work in 3D #86848

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Jan 5, 2024

Closes #75342

I am finding this difficult to solve in the class reference. CanvasTexture is the odd one among all Texture2Ds, because it explicitly does not work outside of CanvasItems, and that is already documented.

The most that can be done is being more explicit.

Can be cherrypicked for prior versions.

@Mickeon Mickeon requested a review from a team as a code owner January 5, 2024 20:57
@Mickeon Mickeon force-pushed the documentation-canvas-texture-note branch from 9afd4a1 to 52d0625 Compare January 6, 2024 00:43
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@clayjohn clayjohn added this to the 4.3 milestone Jan 6, 2024
@clayjohn clayjohn added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 6, 2024
@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 8, 2024
@akien-mga akien-mga merged commit f5e2529 into godotengine:master Jan 8, 2024
15 checks passed
@Mickeon Mickeon deleted the documentation-canvas-texture-note branch January 8, 2024 11:14
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document which texture types can be used in a Sprite3D
4 participants