Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_window_safe_area on Android #86761

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix get_window_safe_area on Android #86761

merged 1 commit into from
Jan 4, 2024

Conversation

Alex2782
Copy link
Contributor

@Alex2782 Alex2782 commented Jan 3, 2024

Fixes: #61467

metrics removed, was not used in the function.

Test: #61467 (comment)

@Alex2782 Alex2782 requested a review from a team as a code owner January 3, 2024 20:06
@akien-mga akien-mga changed the title Fix 'get_window_safe_area' on Android Fix get_window_safe_area on Android Jan 3, 2024
@akien-mga akien-mga added bug platform:android cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:porting labels Jan 3, 2024
@akien-mga akien-mga added this to the 4.3 milestone Jan 3, 2024
m4gr3d
m4gr3d approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix!

@akien-mga akien-mga merged commit dbd139c into godotengine:master Jan 4, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Alex2782 Alex2782 deleted the fix_get_windows_safe_area branch January 4, 2024 13:50
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

OS.get_window_safe_area() returns incorrect size on Android when not in fullscreen
4 participants
@Alex2782 @akien-mga @YuriSizov @m4gr3d