Make LineEdit scrolling show as much text as possible
#86732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently my PR also fixes #27421. Quick test seems to indicate "Center" and "Right" alignment behave much better with this change. |
Geometror
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Tested with all align modes, works nicely. I can confirm that this fixes #27421 and most of #27420. (the "jumping" cursor is still present, but fixing that would require implementing clipping which is should be a toggleable feature IMO and is definitely out of scope here)
Although not absolutely necessary, you could add a comment describing what the code snippet does/for what it is needed since it's not that obvious (as part of the ongoing effort to make the code base more maintainable).
TheSofox
force-pushed
the
line-edit-delete-fix
branch
from
6e1a77b to
8661667
Compare
|
Amended commit with additional comment. Thanks for the review and approval. |
|
Thanks! |
KoBeWi
reviewed
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27420
Bugsquad edit: Fixes #27421
This PR makes sure the scrolling in
LineEditshows as much text as possible, such as when you delete text after entering more than the textbox can fit. Previously, it wouldn't update the scrolling on deleting text, now it does. See linked issue for video examples.