Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve saving of built-in resources #86705

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jan 2, 2024

Extends #84630 by adding a special case for resources inside resources.
I also updated script and shader editor to properly handle scripts/shaders inside other resources.

Fixes #86696
Fixes #88894

@KoBeWi KoBeWi added this to the 4.3 milestone Jan 2, 2024
@KoBeWi KoBeWi requested review from a team as code owners January 2, 2024 11:55
@Benpaste
Copy link

Thank you so much... I hope this gets merged soon!

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving, didn't test.

@akien-mga akien-mga merged commit 16bdd83 into godotengine:master Feb 29, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the resourception branch February 29, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants