Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync visual shader's distance fade using circular fade #86596

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Sync visual shader's distance fade using circular fade #86596

merged 1 commit into from
Jun 7, 2024

Conversation

jsjtxietian
Copy link
Contributor

@jsjtxietian jsjtxietian commented Dec 29, 2023 •
edited
Loading

Fixes #86367

@jsjtxietian jsjtxietian requested a review from a team as a code owner December 29, 2023 05:00
@AThousandShips AThousandShips added this to the 4.3 milestone Dec 29, 2023
paddy-exe
paddy-exe approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected now:
image

@jsjtxietian jsjtxietian force-pushed the sync-distance-fade branch from 4617629 to 8d88880 Compare June 7, 2024 03:33
@akien-mga akien-mga merged commit bef8df0 into godotengine:master Jun 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the sync-distance-fade branch June 8, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@paddy-exe paddy-exe paddy-exe approved these changes

Assignees
No one assigned
Labels
bug topic:shaders topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

VisualShader DistanceFade inconsistent with StandardMaterial3D
4 participants
@jsjtxietian @akien-mga @paddy-exe @AThousandShips