Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS.get_system_font_path and OS.get_system_font_path_for_text to return correct slashes #86552

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

sepTN
Copy link
Contributor

@sepTN sepTN commented Dec 27, 2023

Fix #86544

The bug also occurs in OS.get_system_font_path_for_text so I've fixed that as well.

Snippet used:

func _ready() -> void:
	print(OS.get_system_font_path("sans-serif"))
	print(OS.get_system_font_path("serif"))
	print(OS.get_system_font_path("monospace"))
	print(OS.get_system_font_path("cursive"))
	print(OS.get_system_font_path("fantasy"))

Print result:
image

@sepTN sepTN requested a review from a team as a code owner December 27, 2023 16:21
@sepTN sepTN changed the title Fix OS.get_system_font_path and OS.get_system_font_path_for_text to return correct value Fix OS.get_system_font_path and OS.get_system_font_path_for_text to return correct slashes Dec 27, 2023
@YeldhamDev YeldhamDev added this to the 4.3 milestone Dec 27, 2023
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 2, 2024
@akien-mga akien-mga merged commit 3e67dc1 into godotengine:master Jan 2, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS.get_system_font_path returns a path with mixed back and forward slashes
4 participants