Fix CSGShape3D's _mesh_changed to be thread safe
#86538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjtxietian
force-pushed
the
fix-shape-thread-error
branch
from
73aa7d9 to
8814ba5
Compare
|
The call could always be deferred, no? I don't see why a condition would be useful. |
jsjtxietian
force-pushed
the
fix-shape-thread-error
branch
from
8814ba5 to
5e4dafb
Compare
KoBeWi
approved these changes
Aug 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86381
If in a node safe thread, just call
update_gizmosdierctly, otherwise usecall_deferred