Fix ScriptLanguageExtension::_find_function argument names

[touilleMan]

ScriptLanguageExtension::_find_function documentation is currently wrong when compared to it GDScript implementation:

godot/modules/gdscript/gdscript_editor.cpp

Line 212 in 13a0d6e

int GDScriptLanguage::find_function(const String &p_function, const String &p_code) const {

[AThousandShips]

This can't be changed like this, the binding is here:

godot/core/object/script_language_extension.cpp

Line 110 in 13a0d6e

GDVIRTUAL_BIND(_find_function, "class_name", "function_name");

Not in GDScript, which isn't a ScriptLanguageExtension but a ScriptLanguage in the first place

The discrepancy is an issue, but this will not be a valid fix as the documentation generation won't match

[AThousandShips]

The problem here is that I don't know that this can be changed without breaking compatibility with extensions, I'm not sure if these bound arguments are compatibility relevant for other languages and binds

[touilleMan]

This can't be changed like this, the binding is here:

You're right I should have modified this part too ! (I've updated my PR)

Not in GDScript, which isn't a ScriptLanguageExtension but a ScriptLanguage in the first place

True, I was pointing out GDScript given it is the standard ScriptLanguage, and ScriptLanguageExtension is just a wrapper over ScriptLanguage.

The keypoint is that ScriptLanguageExtension exposes a _find_function method that is used to implement ScriptLanguage::find_function:

godot/core/object/script_language_extension.h

Line 374 in 13a0d6e

EXBIND2RC(int, find_function, const String &, const String &)

So in the end, ScriptLanguageExtension::_find_function should have the same signature as ScriptLanguage::find_function.

The problem here is that I don't know that this can be changed without breaking compatibility with extensions

The fix is only on the name of the parameters, are you sure this breaks compatibility ?

[AThousandShips]

The fix is only on the name of the parameters, are you sure this breaks compatibility ?

I'm not sure, that's why I said "I don't know if this can be done without breaking compatibility" 🙂

CC @dsnopek

[dsnopek]

I don't know that this can be changed without breaking compatibility

Yeah, I think this is fine! It doesn't change how the arguments are used, only their names. From the perspective of GDExtension, arguments are only positional, the names aren't significant.

[akien-mga]

Thanks!