Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve EditorDirDialog #86486

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Improve EditorDirDialog #86486

merged 1 commit into from
Jan 3, 2024

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Dec 24, 2023 •
edited
Loading

  • Automatically selects the newly created directory
  • Automatically selects "res://" when nothing is selected
  • Fixes an error when overwrite/replace dialog appears
  • Changes "copy checkbox + action button" to "copy button + move button"
  • Double clicking a directory (un)collapses it instead of copy/move
  • Moves "Create Folder" to top row for better UX
  • Uses DirectoryCreateDialog for "Create Folder"
Before After
ksnip_20231224-140532 image

@timothyqiu timothyqiu added this to the 4.3 milestone Dec 24, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner December 24, 2023 06:30
KoBeWi
KoBeWi reviewed Dec 24, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
@zolrath
Copy link

zolrath commented Dec 25, 2023

This may not be important but in every other dialog and menu I can see in Godot, Cancel is the last/far right option.
However, in this menu, Cancel is a middle option.

Is there a UI/UX standard for the location of the Cancel button in Godot?

@timothyqiu timothyqiu force-pushed the move-copy-dialog branch 2 times, most recently from 42ab300 to 0772c05 Compare December 25, 2023 09:08
@timothyqiu
Copy link
Member Author

Moved "Create Folder" to the top row so that the Cancel button is no longer in the middle :P

image

Also changed "Create Folder" to use DirectoryCreateDialog, the same as FileSystem dock.

image

@timothyqiu
Improve EditorDirDialog
a42ead5 
* Automatically selects the newly created directory
* Automatically selects "res://" when nothing is selected
* Fixes an error when overwrite/replace dialog appears
* Changes "copy checkbox + action button" to "copy button + move button"
* Double clicking a directory (un)collapses it instead of copy/move
* Uses DirectoryCreateDialog for "Create Folder"
@akien-mga akien-mga merged commit 00cc23f into godotengine:master Jan 3, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the move-copy-dialog branch January 3, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@timothyqiu @zolrath @akien-mga @KoBeWi