Enable global classes in subfolders of res://addons/ #86325
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets
GlobalClass
classes get added to the "Create New Node" dialog no matter where they are underaddons/
as long as it's not in a disabled plugin (or any subfolder of such as those are assumed to belong to the disabled plugin).This also then lets you keep non-plugin files under
addons/
and have theirGlobalClass
es work, as seems encouraged by https://docs.godotengine.org/en/stable/tutorials/best_practices/project_organization.html saying "In general, keep third-party resources in a top-level addons/ folder, even if they aren't editor plugins. This makes it easier to track which files are third-party."Fixes #78400.
The code could presumably be optimised some e.g. by not using
String::split
, but I'm guessing code clarity and brevity takes preference over squeezing out performance here?