Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default blend_left consider current blend amount #86221

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

TokageItLab
Copy link
Member

Fixes #86216.

The current animation is added to the blend list when a new animation is played, but blend_left must be based on the current blend amount at that time.

@TokageItLab TokageItLab added bug regression topic:animation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 16, 2023
@TokageItLab TokageItLab added this to the 4.3 milestone Dec 16, 2023
@TokageItLab TokageItLab requested a review from a team as a code owner December 16, 2023 00:46
@TokageItLab TokageItLab changed the title Make default blend_left consider current blend amount Make default blend_left consider current blend amount Dec 16, 2023
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM! 👍

@YuriSizov YuriSizov merged commit 0eb11e5 into godotengine:master Jan 22, 2024
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@TokageItLab TokageItLab deleted the fix-blend-left branch February 14, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unexpected change in behavior of animation blending using AnimationPlayer in 4.2
3 participants