Fix so undoing complex operations in TextEdit will restore selections
#86118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfajriharsuda
approved these changes
Dec 13, 2023
Paulb23
reviewed
Dec 17, 2023
There was a problem hiding this comment.
LGTM.
Nice spot, looks like it was missed out as we set current_op.start_carets; in begin_complex_operation but as it's TextOperation::TYPE_NONE; it gets overwritten by the new op thus we lose the original caret state.
Could you add a unit test to capture this behaviour?
TheSofox
force-pushed
the
complex-undo-select-fix
branch
from
560c4af to
4b82cac
Compare
|
Amended commit with Unit Test. I confirmed it failed on master but passed on this branch. It tests for the exact behaviour that this PR fixes. |
Paulb23
approved these changes
Dec 20, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72769
When doing a complex operation in TextEdit (using
begin_complex_operationandend_complex_operationto start and end them), undoing one of these operations should have restored the original text selections, however in some cases (especially with multicarat selections), the selections wouldn't be properly restored.It seems that there was an effort to code this in before, but it was either not finished or more likely broken by subsequent code changes. This PR fixes this using the existing system.