Remove dead code from DisplayServerWindows::window_set_size

[0x0ACB]

The removed code will in fact just recreate the swapchain with the same parameters it is already created with. While
context_vulkan->window_resize(p_window, w, h); is called with the updated parameters,

godot/drivers/vulkan/vulkan_context.cpp

Line 1981 in a9f444b

VkExtent2D swapchainExtent = _compute_swapchain_extent(surfCapabilities, &window->width, &window->height);

will reset it to the current window size since the window has not yet been resized.

Also MoveWindow is a synchronous call, meaning this line here will be executed before the function returns

godot/platform/windows/display_server_windows.cpp

Line 3773 in a9f444b

context_vulkan->window_resize(window_id, window.width, window.height);

MoveWindow sends the WM_WINDOWPOSCHANGING, WM_WINDOWPOSCHANGED, WM_MOVE, WM_SIZE, and WM_NCCALCSIZE messages to the window.

So currently calling window_set_size will recreate the swapchain twice.

[clayjohn]

Looks good to me. window_resize() is just a stub for Windows while window_resize is typically called as a consequence of MoveWindow() (it is only not called when the size is not being changed).

This PR will need a rebase, because context_vulkan was renamed. But it will be a trivial rebase

[bruvzg]

GL resize part (even if it's not really doing anything right now) probably should be moved to WM_WINDOWPOSCHANGED instead of removing it, currently it's only calling RD window_set_sized.

[0x0ACB]

Hmm, to be fair I didn't retest this, but when I initially pushed this PR it worked just fine without. And it still should, the window can be resized externally without ever calling window_set_size so the code to handle resizing needs to be already present somewhere else.

[bruvzg]

In the Windows GL manager implementation these functions do nothing, so it should work fine without it. But I think it should call it from WM_WINDOWPOSCHANGED anyway, just in case GL manager ever change, and for consistency with other platforms.

[0x0ACB]

Ah I see what you mean. Will add it

[DarioSamo]

Tested, works fine here with no validation errors!

[akien-mga]

Thanks!