Bump minimum SCons version to 4.0 #85968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Matches minimum version used by godot-cpp
|
Note that Ubuntu 20.04 only has SCons 3.1.2 packaged, but Ubuntu 22.04 has SCons 4.0.1: https://packages.ubuntu.com/search?keywords=scons That said, we recommend the use of pip-packaged SCons as opposed to distribution-packaged SCons. This makes it easy to get the latest SCons version regardless of your Linux distribution. |
|
Partially superseded by #92043. We can still consider moving to 4.0+ in the near future though. |
|
Superseded by #99134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now matches the minimum version used by godot-cpp. In addition, adjusted a handful of sections that needed workarounds for non-4.0 versions; namely:
compile_dbis now just natively available &methods.dumpis replaced with a built-in alternative. GitHub Actions already have a minimum version of 4.4 specified, so no changes are needed there (unless we wanted to deliberately downgrade).