Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Shapecast safe/unsafe fraction difference in class reference #85839

Conversation

romlok
Copy link
Contributor

@romlok romlok commented Dec 6, 2023

This clarifies the difference between get_closest_collision_safe_fraction and the equivalent unsafe version in the class reference for both Shapecast2D and Shapecast3D classes.
I've added some explanation of the implementation to the unsafe descriptions, since if one isn't aware of the implementation, the current descriptions seem linguistically equivalent!

Issue: godotengine/godot-docs#8552

Current documentation: https://docs.godotengine.org/en/latest/classes/class_shapecast2d.html#class-shapecast2d-method-get-closest-collision-safe-fraction

@romlok romlok force-pushed the clarify-get-closest-collision-unsafe-fraction branch from 4e425b7 to 4359dc4 Compare December 6, 2023 21:26
@akien-mga akien-mga merged commit 3d54575 into godotengine:master Apr 8, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants