Fix CanvasOcclusionShaderRD format error with double precision build. #85822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:4.2
|
I'm surprised this is only causing issues on macOS, native Vulkan support for this format doesn't look great either: |
clayjohn
reviewed
Dec 6, 2023
There was a problem hiding this comment.
As Sakrel pointed out, 64 bit vertex formats are not well supported on Vulkan devices. Additionally, they can lead to nasty crashes even on "supported" devices.
I would just remove the ability to use 64 bits here and make everything use the new codepath that you have added for Mac
Done. |
bruvzg
changed the title
clayjohn
approved these changes
Dec 6, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2D shadows in the double precision build.
MoltenVK can't use 64-bit formats since Metal doesn't support it.
Fixes #70879
Fixes #78008