-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to install android build template for export #85819
Add option to install android build template for export #85819
Conversation
That's pretty cool, definitely helps when people download projects or templates that require this to be installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea!
I tested this by removing the android/build
directory in a Quest project, and then running godot --headless --export-debug "Quest" --export-android-build-template
and it correctly recreated the android/build
directory before rebuilding the APK file. (I also tried the same test but omitting the --export-android-build-template
and it fails with the expected message about the build templates not being installed in the project.)
I also skimmed the code, and it looks good to me!
The feature sounds good. I'm not fully sold on the name, as it starts with Architecturally though, I'm not fully satisfied with the implementation, as it breaks platform encapsulation, adding Android specific code in That being said, the issue pre-exists this PR, since |
This PR adds a new "--install-android-build-template" command-line option which causes the android build template to be installed before exporting the project.
7910b5d
to
988c1bf
Compare
In the previous version I used the name How's about
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I still have architectural concerns with the way we do this as pointed above, but this predates this PR.
Thanks! |
This PR adds a new "--export-android-build-template" command-line option which causes the android build template to be installed before exporting the project.