Implement render info counters for the 2D renderer

[clayjohn]

This provides information for the debug monitors for 2D objects.

For now all the draw data is compiled together for the performance monitors to maintain consistency with previous versions, but it can be reported separately if the information is pulled from viewport_get_render_info().

Fixes: #8373 (6 year old bug report 👀)

RD renderer (note draw calls and objects drawn are the same):

Compatibility renderer:

[Zireael07]

Finally!

[lawnjelly]

Looks good. 👍

In long run would be nice to report separately from 3D as in the amazing work in 3.x.

[Calinou]

Tested locally with all rendering methods, it works as expected.

It's interesting to note two things about 2D rendering (these apply to all rendering methods):

• A Label with a single character thas has no font outline or shadow results in 6 primitives drawn. I'd expect 2 primitives to be drawn per character instead. An empty Label doesn't result in any primitives or draw calls as expected.
• Invisible characters such as spaces add the same number of draw calls/primitives as visible characters. I'd expect these to not have to be drawn, though bitmap fonts could in theory make these visible (I'm not aware of any such fonts).

[clayjohn]

• A Label with a single character thas has no font outline or shadow results in 6 primitives drawn. I'd expect 2 primitives to be drawn per character instead. An empty Label doesn't result in any primitives or draw calls as expected.

That was an oversight on my part. I forgot to add the conversion from Vertex/Index to "primitive"

• Invisible characters such as spaces add the same number of draw calls/primitives as visible characters. I'd expect these to not have to be drawn, though bitmap fonts could in theory make these visible (I'm not aware of any such fonts).

That seems odd, but it must be coming from the font system as the renderer doesn't detect if the section of a texture being used is fully transparent

[Calinou]

That seems odd, but it must be coming from the font system as the renderer doesn't detect if the section of a texture being used is fully transparent

@bruvzg Any ideas about this?

[akien-mga]

That seems odd, but it must be coming from the font system as the renderer doesn't detect if the section of a texture being used is fully transparent

@bruvzg Any ideas about this?

I suggest opening a bug report about this, as I'll merge this PR now :)

[akien-mga]

Thanks!

[Ostreicher]

not working for me. i get zero objects drawn like here #74060 (comment)
print(get_viewport().get_render_info(Viewport.RENDER_INFO_TYPE_VISIBLE,Viewport.RENDER_INFO_DRAW_CALLS_IN_FRAME))
0

[AThousandShips]

What version are you on? If you're on 4.2 or 4.1 this isn't available, this is 4.3 only

Also this one is different, this isn't the same, this isn't supported for that method at the moment, you should use:

print(RenderingServer.viewport_get_render_info(get_viewport().get_viewport_rid(), RenderingServer.VIEWPORT_RENDER_INFO_TYPE_CANVAS, RenderingServer.VIEWPORT_RENDER_INFO_DRAW_CALLS_IN_FRAME))

[AThousandShips]

I'll go ahead and open a PR for adding the equivalent to Viewport

[Ostreicher]

ty ! i am indeed using 4.2, didn't see it was 4.3 sorry. thanks :)