Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toaster notifications for import warnings. #85807

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

rakkarage
Copy link
Contributor

Enhances visibility of texture import warnings by showing EditorToaster notifications, in addition to the existing print_line if TOOLS_ENABLED.

Closes: #23117

Thanks.

@rakkarage rakkarage requested a review from a team as a code owner December 5, 2023 21:32
@Calinou Calinou added this to the 4.3 milestone Dec 6, 2023
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

image

Perhaps the normal map detection messages could be compacted together when possible, but this can be left to a future PR.

@akien-mga akien-mga merged commit d26a3f1 into godotengine:master Dec 12, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a JPEG-Image as both the albedo texture and the normal texture turns it yellowish
4 participants