-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TileMapLayer to its own files #85791
Move TileMapLayer to its own files #85791
Conversation
I'm a bit concerned by the circular inclusion, can this not be handled in any other way? |
5b5c3fd
to
1cef90d
Compare
I thought there was not, but I managed to solve it. |
1cef90d
to
6ad47e3
Compare
28b2659
to
d131e7b
Compare
Needs a rebase and we can merge it soon if it unblocks your further work. |
I'll rebase once #84660 is merged, to avoid conflicts. |
@groud You should be able to rebase now! |
New Year's rebase poke ;) |
d131e7b
to
6bc5b3f
Compare
Done! |
Thanks! |
As I mentioned in this proposal, I'd like to move TileMap layers to their own node. This fits the
I prefer to go there step by step. This first PR moves TileMap layer to another file.
The next steps would be:
Basically, the TileMap node could become the equivalent of (TileMapGroup + Children TileMap layers), with layers being internal nodes instead of being explicit ones.