Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for icon_and_font_color editor setting #85491

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

BNTFryingPan
Copy link
Contributor

the documentation for the interface/theme/icon_and_font_color incorrectly states that the "dark" option makes the icons light, suitable for dark themes, and the "light" option makes the icons dark, suitable for light themes. this pr changes the documentation to say that the "dark" option makes the icons dark, suitable for light themes, and the "light" option makes the icons light, suitable for dark themes

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the note above, this change seems to be correct. We consider that the editor has a dark theme if icon_font_color_setting == LIGHT_COLOR.

@YuriSizov YuriSizov modified the milestones: 4.x, 4.3 Nov 29, 2023
@YuriSizov YuriSizov added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 29, 2023
@BNTFryingPan
Copy link
Contributor Author

removed the line number from the link and changed it to say "the set of rules defined in this file"

@AThousandShips
Copy link
Member

Please squash your commits into one, see here

@BNTFryingPan BNTFryingPan force-pushed the editor-icon-color-docs branch from 9f6e039 to de59872 Compare November 30, 2023 19:00
@BNTFryingPan
Copy link
Contributor Author

just wanted to make sure: this is all set, right?

@YuriSizov
Copy link
Contributor

Yep!

@akien-mga akien-mga changed the title fix documentation for icon_and_font_color editor setting Fix documentation for icon_and_font_color editor setting Dec 5, 2023
@akien-mga akien-mga merged commit 708efe9 into godotengine:master Dec 5, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga
Copy link
Member

Cherry-picked for 4.2.1.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants