Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message about resources in use at exit #85464

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Improve message about resources in use at exit #85464

merged 1 commit into from
Dec 19, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 28, 2023

The message says "run with --verbose" even if you are running in verbose mode. This PR fixes it.

@KoBeWi KoBeWi added this to the 4.3 milestone Nov 28, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner November 28, 2023 12:22
YuriSizov
YuriSizov approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also put the number of resources into the message? Could be useful at a glance.

@KoBeWi KoBeWi force-pushed the only_say_verbose_when_not_verbose branch from 57ed1a2 to f8f8fe0 Compare November 28, 2023 13:01
@YuriSizov YuriSizov merged commit d8a65b3 into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@KoBeWi KoBeWi deleted the only_say_verbose_when_not_verbose branch December 19, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@KoBeWi @YuriSizov