-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to show code hint and code completion at the same time #85436
Conversation
I think it would be better if the code hint did not change position, but always appear at the opposite side from the completion popup. So it would be at the top by default. |
8ce2888
to
ef3fad8
Compare
The completion popup is contextual and doesn't necessarily appear where there is a code hint, so it's not a good idea to define code hint's position in terms of the completion popup's position. If the code hint always appears at the top, then we may have to deprecate In Visual Studio, the code hint is always placed above, while the code completion automatically repositions itself and may be placed between the edited line and the code hint: Taking inspiration from Visual Studio, I've made it so the code completion can reposition itself below or above the code hint to fit inside the screen. godot_issue-85401-below-v2.mp4godot_issue-85401-above-v2.mp4 |
27fa1d2
to
e76a4c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
Make code completion position more consistent Add whitespace before if
e5adb05
to
3744ef5
Compare
Applied suggestions and rebased on your behalf. |
Thanks! |
Fixes #85401
See below demo: (When code completion appears above, code hint is moved below, and vice versa. When there is no code completion, the value of
code_hint_draw_below
is used to determine where the code hint is)godot_issue-85401-below.mp4
godot_issue-85401-above.mp4